fix(deps): add lxml-html-clean to napari extra (+ remove old logos) - #36
Merged
Conversation
napari's notebook_display imports lxml.html.clean, which moved to a separate lxml-html-clean package in lxml>=5.2; without it napari.Viewer() raises ImportError. Pull it into the napari extra so view_in_napari works out of the box. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
napari fix
view_in_napari()failed atnapari.Viewer()with:napari's
notebook_displayimportslxml.html.clean, which split out of lxml in 5.2; napari only catchesModuleNotFoundError, so the newImportErrorleaks. Addlxml-html-cleanto thenapariextra so it's pulled in.Immediate workaround for an existing env:
pixi add --pypi lxml-html-clean.Also
Removes the placeholder logo SVGs (
docs/assets/) — a new logo is in progress.🤖 Generated with Claude Code