migrate用ecspresso configにservice定義が不足していたので追加 - #544
Merged
Conversation
ecspresso run は awsvpc Fargate task の networkConfiguration を service_definition から解決する仕様で、未定義だと register 成功後の RunTask で「service_definition is not defined」エラーになる。 migrate は常駐サービスではないため deploy は叩かない前提で、 networkConfiguration / launchType の供給のみを目的とした最小の service-def を置く。 セキュリティグループは sidekiq 用を流用した。postgres SG の受け入れ 側に既に sidekiq SG が登録済みなので、migrate 専用SGを切ると terraform 変更と apply が連動する。RDSへの到達経路としては同等なので 新規SGを切るほどのメリットは無いと判断。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.