Skip to content

Proposal: Adjust the basis of height for collapsing status #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acid-chicken wants to merge 2 commits into
base: imastodon
Choose a base branch
from
+2 −2
Open

Proposal: Adjust the basis of height for collapsing status #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62fd395
Revert "Double the threshold for "read more" functionality (#8835)"
acid-chicken Aug 28, 2020
a692e7a
Adjust max-height of collapsed content of status
acid-chicken Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/mastodon/components/status_content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import PollContainer from 'mastodon/containers/poll_container';
import Icon from 'mastodon/components/icon';
import { autoPlayGif } from 'mastodon/initial_state';

const MAX_HEIGHT = 642; // 20px * 32 (+ 2px padding at the top)
const MAX_HEIGHT = 322; // 20px * 16 (+ 2px padding at the top)

export default class StatusContent extends React.PureComponent {

Expand Down
2 changes: 1 addition & 1 deletion app/javascript/styles/mastodon/components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@
}

.status__content.status__content--collapsed {
max-height: 20px * 15; // 15 lines is roughly above 500 characters
max-height: 20px * 16; // 288 CJK characters (w = 18ic, h = 16lh)
}

.status__content__read-more-button {
Expand Down