Security/bump Js Yaml 4.3.0#96
Merged
Merged
Conversation
js-yaml build dependency updated from 4.1.1 to 4.3.0 to address a denial-of-service vulnerability (GHSA-h67p-54hq-rp68). No runtime theme changes.
The save_dir path pointed to a local user home directory that doesn't apply generally to the repo.
Tracks the patched js-yaml version (GHSA-h67p-54hq-rp68) in git for reproducible installs, consistent with other Imagewize themes. Still excluded from the WP.org distribution zip via .distignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a security vulnerability in the
js-yamlbuild dependency by bumping it from 4.1.1 to 4.3.0, addressing a denial-of-service vulnerability (GHSA-h67p-54hq-rp68). Thepackage-lock.jsonwas re-added with the patched version, and the theme version was bumped to 4.6.4 acrossstyle.css,readme.txt, andCHANGELOG.mdin accordance with the project's version management convention. Additionally, a machine-specificsession_loggingconfiguration block was removed from.vibe/config.tomlto eliminate a hardcoded local file path that should not be checked into the repository. This is a build-tooling-only change with no impact on theme templates, patterns, or runtime user-facing functionality.Security:
js-yamlfrom 4.1.1 to 4.3.0 to remediate a DoS vulnerability (GHSA-h67p-54hq-rp68), with the fix captured by re-addingpackage-lock.json.js-yamlis only used in the build/tooling chain, not in theme templates or patterns.Version Management:
style.cssandreadme.txt(Stable tag), per the project's convention of updating all version references together.## [4.6.4]entry toCHANGELOG.mdand a matching changelog block inreadme.txt, documenting the security fix and clarifying it as a technical, non-user-facing change.Configuration Cleanup:
[session_logging]block from.vibe/config.toml, which contained a hardcoded, machine-specificsave_dirpath (/Users/jasperfrumau/.vibe/logs/session) that had no place in shared project configuration.Files Changed:
.vibe/config.toml(Modified)CHANGELOG.md(Modified)readme.txt(Modified)style.css(Modified)Dependency lock files updated: package-lock.json,