Fix/admin Settings Assets#4
Merged
Merged
Conversation
The plugins_url() call in aludra_enqueue_admin_assets() passed a directory path instead of a file path, so admin-settings.css/js never actually enqueued and the Settings -> Aludra page rendered as a bare, unstyled checkbox list. Also fixes the child-row indentation CSS selector (data-parent lives on the input, not the tr), restores dependency styling after "Disable All", and corrects an incomplete settings default used for carousel/testimonial-grid asset loading. Removes stale references to the never-implemented aludra/nav-builder block and updates the documented block count/list to match the 13 blocks currently shipped. Bump version to 2.9.2.
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version:
2.9.2The Settings → Aludra admin screen rendered as an unstyled checkbox list because its CSS and JS never loaded, and several smaller admin UI and documentation issues had accumulated. This is a patch release focused entirely on repairing the admin experience — no new functionality.
Bug Fixes:
plugins_url()was called with a directory path (__DIR__ . '/../..') instead of a file path, producing a URL with a stray../that resolved to the wrong location. Switched toALUDRA_PLUGIN_URLsoadmin-settings.css/admin-settings.jsload correctly.data-parenton the<input>, not the<tr>, so thetr[data-parent]CSS selector never matched. Child rows (Slide, FAQ Tab Answer) are now tagged with analudra-child-rowclass in JS and indented via that class.handleDependencies()so child-block disabled-state styling stays in sync.wp_enqueue_scriptsaludra_enableddefault listed onlycarousel, out of sync with the full 13-block block-discovery default. On a fresh install (before the option is saved) this could skip loading Testimonial Grid assets. The two defaults now match.Documentation and Version Updates:
aludra/nav-builderblock (inCLAUDE.mdandreadme.txt) — Mega Menu can only be placed insidecore/navigation.CLAUDE.mdand the plugin description header to reflect the full current block list (13 blocks, not 6).2.9.2acrossaludra.php,readme.txt, andCHANGELOG.md.Files Changed:
aludra.php— asset URL fix, complete enqueue default, version/description bumpincludes/admin/settings-page.php—plugins_url()→ALUDRA_PLUGIN_URLassets/admin/admin-settings.css— child-row selector, removed unused warning stylesassets/admin/admin-settings.js— tag child rows, sync Enable/Disable AllCLAUDE.md— block list, nav-builder removalCHANGELOG.md— 2.9.2 notesreadme.txt— stable tag + changelog