fix(sidebar): scope attention sorting to projects and workspaces - #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Waiting and error tab priority now stays within the sidebar container where the tab belongs, preventing multi-tab source workspaces from jumping around as session status changes.
Expected impact
Design notes
folderGroupHasProjectPriorityStatuspromotes a workspace row only when it has at most one session and that session needs attention.orderSessionsByPrioritycontinues to stable-partition their child sessions internally.Test plan
pnpm run test— 109 files, 1,290 tests passedpnpm run typecheck— passedpnpm run build— production build passedpnpm exec playwright test tests/e2e/sidebar.spec.ts --grep "priority sorting" --workers=1 --repeat-each=3— 6/6 passedgit diff --check— passed