fix(projects): sync sidebar source-folder order with project settings - #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep a multi-root project source-folder order consistent between the sidebar and Project Settings.
Project.source_paths.Expected impact
Design notes
Project.repo_pathremains the primary-root identity; only existing extra roots insource_pathsare reordered.Test plan
pnpm run typecheckpnpm exec vitest run src/store.test.ts src/lib/sidebarProjectItems.test.ts— 186 passedcargo test --manifest-path src-tauri/Cargo.toml reordering_project_sources_preserves_membership— 1 passedpnpm exec playwright test tests/e2e/project-settings.spec.ts— 7 passedpnpm run buildrustfmt --edition 2021 --check src-tauri/src/commands.rsNotes
a2494f8.