feat(sidebar): keep multi-root project headers project-only - #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-root project headers now delegate root-scoped creation to the individual root rows and keep only project-level actions at the group level.
Expected impact
Design notes
source_pathscontains at least one extra root, meaning the primary root plus one or more source roots.Test plan
pnpm run typecheck— passespnpm exec playwright test tests/e2e/sidebar.spec.ts --grep "multi-root project header|project header exposes regular and worktree session buttons"— 2 tests passpnpm run test— 109 files and 1,287 tests passpnpm exec playwright test tests/e2e/sidebar.spec.ts— 52 tests passgit diff --check— passes