Skip to content

#12 Task. Sergey Starushkin - #818

Draft
Sergey-Starushkin wants to merge 3 commits into
ilya4321:masterfrom
Sergey-Starushkin:task12
Draft

#12 Task. Sergey Starushkin#818
Sergey-Starushkin wants to merge 3 commits into
ilya4321:masterfrom
Sergey-Starushkin:task12

Conversation

@Sergey-Starushkin

Copy link
Copy Markdown

No description provided.

@vramaniuk vramaniuk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, privide the direct link to your task success travis build
I'll mark the PR as "Draft", please click "ready for review" when it will be finished. Thank you!

Comment thread task/12-katas-3-tasks.js
let save = data[current.y][current.x];
data[current.y][current.x] = "";

if (step == search.length)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"operator === is always preferable
sometimes ''==' may cause an error
(check at console :
'0' == 0
and '0' === 0)"

Comment thread task/12-katas-3-tasks.js
let newX = current.x + steps[i][0],
newY = current.y + steps[i][1];

if (data[newY][newX] == search[step]) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator === is always preferable

Comment thread task/12-katas-3-tasks.js

for (let i = 1; i < m; i++) {
for (let j = 1; j < n; j++)
if (data[i][j] == search[0]) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator === is always preferable

Comment thread task/12-katas-3-tasks.js
while (stack.length) {
let item = stack.pop();

if (item.string.length == chars.length) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator === is always preferable

Comment thread task/12-katas-3-tasks.js
throw new Error('Not implemented');
let maximums = quotes
.reduceRight((prev, curr) => {
if (prev.length == 0)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator === is always preferable

@vramaniuk
vramaniuk marked this pull request as draft August 25, 2020 10:06
@Sergey-Starushkin
Sergey-Starushkin marked this pull request as ready for review August 31, 2020 19:57
@Sergey-Starushkin

Copy link
Copy Markdown
Author

@vramaniuk

Copy link
Copy Markdown
Collaborator

Dirty PR. Please, see notes for tasks 1-4

And implement previous notes (strikt equality and unequality)

I'll mark the PR as "Draft", please click "ready for review" when it will be finished. Thank you!

@vramaniuk
vramaniuk marked this pull request as draft September 1, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants