CI: PR build check for Windows companion; bump electron 39 + electron-builder 26#2
Open
illixion wants to merge 2 commits into
Open
CI: PR build check for Windows companion; bump electron 39 + electron-builder 26#2illixion wants to merge 2 commits into
illixion wants to merge 2 commits into
Conversation
…der 26 Adds a pull_request trigger (paths: CompanionWindows/**, the workflow) so PRs that touch the Windows companion get a real installer-build check on both arches (x64 + arm64). The release pipeline — macOS jobs, provenance attestation, and release upload — stays main-only. Closes the gap where Dependabot PRs got zero CI from our pipeline. Bumps electron ^33.2.0 -> ^39.8.5 and electron-builder ^25.1.8 -> ^26.15.2 together: electron-builder 25 predates electron 39 and can't package it, so the dep bump is only coherent with both. Supersedes Dependabot #1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR build check for the Windows companion. Adds a
pull_requesttrigger (paths:CompanionWindows/**+ the workflow) so PRs touching the Windows app get a real installer-build check on both arches (x64 onwindows-latest, arm64 onwindows-11-arm). The release pipeline — macOS jobs, provenance attestation, release upload — stays main-only. This closes the gap where Dependabot PRs had zero CI from our pipeline.Coherent electron bump.
electron ^33.2.0 → ^39.8.5andelectron-builder ^25.1.8 → ^26.15.2together. electron-builder 25 predates electron 39 and can't package it, so bumping electron alone (as Dependabot Bump electron from 33.4.11 to 39.8.5 in /CompanionWindows/app #1 did) would break the installer build.Why a new PR instead of merging #1
Dependabot #1 bumped only
electronand had no CI coverage. This PR bumps both deps coherently and adds the check that proves it builds. Supersedes #1 (Dependabot will auto-close once this lands).Verification
The PR check on this very PR is the test: if both Windows legs go green, the bump packages cleanly. Not yet smoke-tested at runtime on a device — the build-green signal covers packaging, not behavior.