feat: add false color enhancement feature.#329
Conversation
RawTherapee has the feature that attenuate false color artifacts on bilinear tab. It will be good for cameras which are uses line- skip instead of hardware binning(e.g. EOSM). It takes quite a long time on processing(EOSM's 3x3 video live view frame change 20fps to 5fps and exporting speed increased by 3-6times.) but give a little bit of increment on overall image quality. Please review the code and result. If sample footage for testing this feature, I would share one of my footages took 3x3 with EOSM.
|
Hi @WB-tommy ! Thanks for the PR. Nice work. The results are stunning for many of my old 5D2 clips. And it is not that slow here on my M1. When artifacts get fixed I still get realtime preview (or close to, 22fps) for FHD clips. Some remarks:
Edit: one more:
|
P.S I did not test 10bit clips that's my fault. I have very a few 10bits clips that recorded with line-skipped sensor data. I would fix that and make pull request again. I would test 10 bit and dual iso footage. I forgot that options. |
have a pinky screen error on image except 14bit footage while false color enhancement is applied. This is caused by wb applying.
|
May I ask footages that gets blue and green edges. If you get green edges on LMMSE, I have the same problem and RawTherapee also has the same problem. However blue edges are something I didn't see with my footages. P.S. I fixed malfunction on below 14bits clip. |
False Color correction feature create more cyan(pinky) lines on edges of high contrast or reconstructed highlight area. Also, removed border slider.
|
Fix cyan pinky border problem. It appears usually where borders of between dark area and very bright area. |
|
Oh yes. That now looks really good. Nice! Edit... hoa... or I'll try to describe here, because it is all over...:
If it's no problem for you, I'd pick the functionality itself into a new branch and build the other parts according to how things were made. I just need time for it... Have you also played a bit around with the iterations slider? For me the ideal settings seems to be the setting which was hardcoded before. I am not sure, but I think I got those hardcoded numbers from the RawTherapee teams code. The false color slider is magic. This one is really great. And I think this is the one which definitively should be added as good as possible. |
RawTherapee has the feature that attenuate false color artifacts on bilinear tab. It will be good for cameras which are uses line- skip instead of hardware binning(e.g. EOSM).
It takes quite a long time on processing(EOSM's 3x3 video live view frame change 20fps to 5fps and exporting speed increased by 3-6times.) but give a little bit of increment on overall image quality. Please review the code and result.
If sample footage for testing this feature, I would share one of my footages took 3x3 with EOSM.