Update to jdk8u482-b08 - #742
Merged
Merged
Conversation
Moves OpenJdkUpdateVersion from 472 to 482 and the ext/openjdk submodule to 69137c64, the tip of ikvm-jdk8u482-b08. This is #716 rebuilt on main. That PR targets develop, which has had no commits since April and none of the CI work from the last few days, so nothing there could have run cleanly. Its content was four files; the two workflow changes it carried, moving the Windows runners to windows-2025 and staging under D:, were attempts at the disk and MSBuild problems that #727 has since solved differently, so they are dropped rather than carried across. Of the five exclude list changes it made, two already landed independently: AsyncClose was widened to generic-all in #730 after showing up as a flake on Windows, and ModalDialogInitialFocusTest in #731. The remaining three are carried over as they were.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates OpenJDK from 8u472 to 8u482-b08. This is #716 rebuilt on
main.Why not just rebase #716
#716 targets
develop, which has had no commits since 26 April and none of the CI work from the last few days. Nothing on that branch could run cleanly regardless of its content, which is most of why it has sat unmerged.What is here
Directory.Build.propsOpenJdkUpdateVersion472 → 482 (OpenJdkBuildNumberis alreadyb08)ext/openjdk69137c64, the tip ofikvm-jdk8u482-b08ExcludeList.txtWhat was dropped
#716 also carried two workflow changes — moving the Windows runners to
windows-2025and staging work underD:. Both were attempts at the MSBuild and disk problems that #727 has since solved properly, withwindows-2025-vs2026andrunner.temp. Carrying them across would undo that.Two of its five exclude-list changes have already landed independently, which is worth noting as corroboration rather than duplication:
AsyncClose— Update to jdk8u482-b08 #716 widened it togeneric-allwith the note that it "used to work at one point on Windows, but it seems to have regressed". Exclude jtreg tests that fail intermittently #730 arrived at the same place from the other direction, after it turned up as an intermittent Windows failure across five runs.ModalDialogInitialFocusTest— landed in Clean up ExcludeList.txt #731.The remaining three are carried over unchanged:
They are annotated as having begun failing with this upgrade. None has been investigated, and the comment says so rather than implying a cause is known.
What this needs from CI
The original #716 ran its OpenJDK suite clean — all 48 partitions passed across net472 and net8.0 on both Windows and Linux. That was in April, against a
developthat has since diverged, so it wants re-establishing here.The failures that actually blocked #716 were never about the JDK: the
lldtoolchain drift, the MSBuild 18 mismatch, and the flake tail, all now fixed onmain.Supersedes #716.