Add fact-grounding and section-organization rules to PR guidelines - #317
Draft
ikuwow wants to merge 1 commit into
Draft
Add fact-grounding and section-organization rules to PR guidelines#317ikuwow wants to merge 1 commit into
ikuwow wants to merge 1 commit into
Conversation
Retrospective #280 items 1 and 2: - Sources and references checklist: operational sections may name an external tool or service only after confirming the project uses it; misattributed rationale from linked sources is Must Fix - Style rules: no property-themed sections; fold such points into the bullet for the change they qualify Item 3 of #280 (hookify rule blocking command substitution) is machine-local placement and stays on the issue. Refs #280 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0156RhYyZmXJn2YdA1rHZztf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Background
Retrospective #280 recorded two fact-grounding failures persisting into an approved plan and PR body (a monitoring vendor the project does not use, and rationale misattributed to an unrelated PR), plus a property-themed section that needed a user editorial pass. pr-selfcheck loads this checklist in Step 3, so both additions take effect on the detection side automatically
Item 3 of #280 (hookify rule blocking
$()/ backtick command substitution in Bash tool calls) involves a machine-local file outside this repository and remains tracked on the issueIssue: #280
Verification