Skip to content

Add fact-grounding and section-organization rules to PR guidelines - #317

Draft
ikuwow wants to merge 1 commit into
mainfrom
pr-guidelines-fact-grounding-280
Draft

Add fact-grounding and section-organization rules to PR guidelines#317
ikuwow wants to merge 1 commit into
mainfrom
pr-guidelines-fact-grounding-280

Conversation

@ikuwow

@ikuwow ikuwow commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

Changes

  • Sources and references (PR Body Checklist): operational sections (verification, rollout, rollback, monitoring) may name an external tool or service only after confirming the project actually uses it; rationale attributed to a linked issue / PR must match that source; violations are Must Fix
  • Style rules: organize sections by reviewer / operator needs; no property-themed sections ("safety valves", "performance notes") — fold each point into the bullet for the change it qualifies

Background

Retrospective #280 recorded two fact-grounding failures persisting into an approved plan and PR body (a monitoring vendor the project does not use, and rationale misattributed to an unrelated PR), plus a property-themed section that needed a user editorial pass. pr-selfcheck loads this checklist in Step 3, so both additions take effect on the detection side automatically

Item 3 of #280 (hookify rule blocking $() / backtick command substitution in Bash tool calls) involves a machine-local file outside this repository and remains tracked on the issue

Issue: #280

Verification

Retrospective #280 items 1 and 2:
- Sources and references checklist: operational sections may name an
  external tool or service only after confirming the project uses
  it; misattributed rationale from linked sources is Must Fix
- Style rules: no property-themed sections; fold such points into
  the bullet for the change they qualify

Item 3 of #280 (hookify rule blocking command substitution) is
machine-local placement and stays on the issue.

Refs #280

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0156RhYyZmXJn2YdA1rHZztf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant