This repository was archived by the owner on Jan 4, 2026. It is now read-only.
Make the driver ready for linux upstream#6
Open
c0d3z3r0 wants to merge 4 commits into
Open
Conversation
iksaif
reviewed
Feb 6, 2018
| ret = -ENOMEM; | ||
| } | ||
|
|
||
| /* value not assigned => wmi call with return value (e.g. change settings) */ |
Owner
There was a problem hiding this comment.
IMHO this is cleaner in a separate function
Contributor
Author
There was a problem hiding this comment.
That point is open to dispute; Personally I like this better because it removes redundant code... let's see what it looks like at the end when everything else is finished
| ret = -EIO; | ||
|
|
||
| /* value assigned -> wmi call returning output */ | ||
| else if(value) { |
Owner
There was a problem hiding this comment.
Add braces if you have empty lines (see scripts/checkpatch.pl to automatically lint the code)
Contributor
Author
There was a problem hiding this comment.
yep, working on this
| return -EIO; | ||
|
|
||
| return thinkpad_wmi_extract_output_string(&output, value); | ||
| obj = output.pointer; |
Owner
There was a problem hiding this comment.
IMHO it was better in smaller functions
| { | ||
| return thinkpad_wmi_simple_call(LENOVO_SET_BIOS_SETTINGS_GUID, | ||
| settings); | ||
| return thinkpad_wmi_call(LENOVO_SET_BIOS_SETTINGS_GUID, settings, NULL); |
Owner
There was a problem hiding this comment.
I like thinkpad_wmi_simple_call() better than having to specify NULL all the time
c0d3z3r0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
more will follow: