Conversation
lreiher
previously approved these changes
Jun 8, 2026
Member
|
Feel free to merge once the final thread is resolved. :) |
Co-authored-by: Lennart Reiher <lennart.reiher@ika.rwth-aachen.de>
RaphvK
enabled auto-merge (squash)
June 11, 2026 06:47
lreiher
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
LABEL devcontainer.metadatain dev images built bydocker-rosthat are also effective when attaching VS Code to a running container, e.g. started in a compose setup. Note that not all devcontainer configuration options are supported, e.g. setting theworkspaceFolder. Closes #80.Make the default command (configured via docker-ros CI variable) available in dev images via
DEFAULT_COMMANDenvironment variable and viarun_default_commandscript. This is only useful if the configured default command is actually used also in compositions and not overridden in the docker compose file. Hence, we should also set launch arguments to environment variables (with fallbacks to default values) in the configured default command. Closes #81.