Improve admin backend list performance#28
Open
HCDD1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Improves the admin backend user list performance by moving filtering and pagination into the database and batching storage usage aggregation for the users on the current page.
Fixes #2
/claim #2
How to use
No UI or API contract changes are required. The existing admin users endpoint should behave the same, but avoid loading every user and every user's documents for each list request.
How it works
countByAdminTrue()for system info instead of loading all users into memory.How I tested it
findAll().Local test execution is currently blocked on this machine because
JAVA_HOMEis not configured and nojavaexecutable is available inPATH.