Add search function within patch viewer#2
Open
roseoriorden wants to merge 3 commits into
Open
Conversation
Allows search within patch files just like vim's search function (i.e. supports regex, same n/N controls, etc). Colors of the matches differ between dark and light mode. Assisted-by: Claude Sonnet 4.5, Claude Code Signed-off-by: Rosemarie O'Riorden <rosemarie@redhat.com>
/<up_arrow>/<down_arrow> search history just like in vim's search. Does not persist across sessions. Assisted-by: Claude Sonnet 4.5, Claude Code Signed-off-by: Rosemarie O'Riorden <rosemarie@redhat.com>
Before this commit, esc and q had the same function inside the patch viewer during a search, which is that they would both exit from the search, and then with a second press they'd exit from the patch viewer and go back to the list of patches. With this commit, esc exits from the patch viewer even mid-search, and q exits from the serach upon the first press, and exits from the patch viewer upon the second press. However, if nothing was found in a search, q will exit from the patch viewer immediately as if an active search was not ongoing. Assisted-by: Claude Sonnet 4.5, Claude Code Signed-off-by: Rosemarie O'Riorden <rosemarie@redhat.com>
Author
|
I am also working to add a search filter to the patch list view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a vim-like expression search /
Supports regex like vim and has the same n/N controls
Assisted-by: Claude Sonnet 4.5, Claude Code