Fix Advanced Lru Cache 142 - #234
Merged
Merged
Conversation
Reading an expired item removed it from both queues but left it in the map, so the stale entry kept counting toward the capacity and later puts evicted live items instead. Drop the whole entry, and keep the map in sync with the touched instance re-inserted into the priority queue. The README also described eviction as "earliest expiry time, then lowest priority, then LRU", while the solution and tests evict by priority and last used only (expiry gates validity, not ordering). Align the wording and document the O(n) bound of the PriorityQueue based implementation. Refs #142 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.