Fix frame script dispatch and mouse hover event tracking - #88
Open
matthewdean wants to merge 2 commits into
Open
Fix frame script dispatch and mouse hover event tracking#88matthewdean wants to merge 2 commits into
matthewdean wants to merge 2 commits into
Conversation
2 tasks
matthewdean
marked this pull request as ready for review
March 25, 2026 08:03
matthewdean
force-pushed
the
bionicle-atticmedia-behaviors
branch
2 times, most recently
from
March 29, 2026 00:42
bc860d5 to
8dc4fbc
Compare
Owner
|
@matthewdean This has some conflicts with the other changes made to the score, it's also introducing some playback issues on previously working games, such as Furni Factory, Habbo and some Nintendo games. Let me know how I can help you debug those issues |
Channel 0 behavior instances now receive beginSprite via targeted dispatch instead of the frame/movie script path. Also dispatch enterFrame/exitFrame to channel 0 behaviors in the all-behaviors loop, matching ScummVM's script channel handling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use get_interactable_sprite_at instead of get_sprite_at for hover tracking, matching Director behavior where only sprites with mouse handlers participate in hover state. Also clear hovered_sprite and fire mouseLeave when the mouse leaves all interactable sprites. Fixes repeated mouseEnter events when non-scripted sprites overlap scripted ones (e.g. Bionicle Atticmedia character selection flyouts). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
matthewdean
force-pushed
the
bionicle-atticmedia-behaviors
branch
from
April 4, 2026 22:56
8dc4fbc to
56c9bee
Compare
matthewdean
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_interactable_sprite_atfor mouse hover tracking so only sprites with mouse handlers participate in hover state (matching Director behavior)hovered_spriteand firemouseLeavewhen mouse leaves all interactable spritesContext
Replaces the previous large score parsing refactor with two targeted fixes. The score parsing on main already handles D6+ games correctly — the actual issues were event dispatch routing and mouse event semantics.
Verified against ScummVM (
engines/director/events.cpp,score.cpp) and Adobe Director documentation.Test plan
wasm-pack build --dev --target web🤖 Generated with Claude Code