Fix Director text decoding and leading whitespace layout - #235
Open
luismgl wants to merge 6 commits into
Open
Conversation
Collaborator
|
For which movie did you make those changes? Would be good to know in order to test it properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
Classic Mac Director movies can store accented text as Mac Roman bytes. Treating those bytes as Windows-1252 produces incorrect glyphs. Separately, some Director text members use leading whitespace as authored positioning inside the member rectangle; dropping it collapses otherwise distinct glyph runs onto the same origin.
Both changes are format/runtime rules and do not alter the public polyfill API or rely on movie names, member IDs, or character heuristics.
Validation
npm run build-vmnpm run build-polyfill