Skip to content

Home page cleanup: Fix broken link, add alt text, avoid duplicate links for screen reader users#1381

Open
alice-blue wants to merge 9 commits into
iftechfoundation:mainfrom
alice-blue:aria-hidden-on-home-page
Open

Home page cleanup: Fix broken link, add alt text, avoid duplicate links for screen reader users#1381
alice-blue wants to merge 9 commits into
iftechfoundation:mainfrom
alice-blue:aria-hidden-on-home-page

Conversation

@alice-blue

@alice-blue alice-blue commented May 30, 2026

Copy link
Copy Markdown
Contributor

This PR makes the following changes to the home page.

For "News on [Game Title]" items in the Games section:

  • Fix broken cover art links (they didn't include the TUID before)
  • Prefer showing cover art vs. showing the profile image of the user (this just made more sense to me for news announcements about a game, and @salty-horse agreed)
  • If the profile image of the user is shown anyway (because no cover art for the game is available), give alt text of the user's name so that screen reader users know what happens if they click on the link. The user's name doesn't otherwise appear in the news announcement, so in this case the link and the alt text are not redundant.

Everywhere on the home page:

Whenever cover art images or user images are redundant with nearby links, use aria-hidden and tabindex to avoid repeating that link for screen reader users. Use alt="" on the images in these cases where it is not already present (I wasn't sure about this, but since assistive technology has been around longer than ARIA, I guess it makes sense as a fallback in the event that ARIA, and therefore aria-hidden, is not understood? Old stackoverflow answer )

This PR fixes #1380. Also works towards addressing #1377. Tested with NVDA.

… next to a news item, use aria-hidden ad tabindex to avoid redundant links for screen reader users.
… to avoid duplicate links for screen reader users.
…nd alt="" on image links to avoid duplicate links for screen reader users
…duplicate links for screen reader users. (This had aria-label before, but the result of that was that you heard two identical links announced in a row, both annoucing the game title.)
…f the user's name, because this is not a redundant link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In the games section of home page, clicking a game's cover art next to "News on [Game Title]" doesn't work

1 participant