Home page cleanup: Fix broken link, add alt text, avoid duplicate links for screen reader users#1381
Open
alice-blue wants to merge 9 commits into
Open
Conversation
…o avoid duplicate links for screen readers
… next to a news item, use aria-hidden ad tabindex to avoid redundant links for screen reader users.
… to avoid duplicate links for screen reader users.
…nd alt="" on image links to avoid duplicate links for screen reader users
…duplicate links for screen reader users. (This had aria-label before, but the result of that was that you heard two identical links announced in a row, both annoucing the game title.)
…f the user's name, because this is not a redundant link.
… in the "News on [Game Title]" entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to the home page.
For "News on [Game Title]" items in the Games section:
Everywhere on the home page:
Whenever cover art images or user images are redundant with nearby links, use aria-hidden and tabindex to avoid repeating that link for screen reader users. Use alt="" on the images in these cases where it is not already present (I wasn't sure about this, but since assistive technology has been around longer than ARIA, I guess it makes sense as a fallback in the event that ARIA, and therefore aria-hidden, is not understood? Old stackoverflow answer )
This PR fixes #1380. Also works towards addressing #1377. Tested with NVDA.