Skip to content

feat(cli): add zcode agent profile - #917

Merged
XiaoSeS merged 1 commit into
iflytek:mainfrom
twodogegg:feat/zcode-agent-profile
Oct 16, 2026
Merged

XiaoSeS merged 1 commit into
iflytek:mainfrom
twodogegg:feat/zcode-agent-profile

Conversation

@twodogegg

Copy link
Copy Markdown
Contributor

Summary

  • Adds a first-class zcode agent profile (display name ZCode) so Skills can be installed with --agent zcode:
    • project-level: <project>/.zcode/skills/
    • user-level: ~/.zcode/skills/
  • Follows the existing makeProfile pattern with automatic detection of both scopes, and registers the profile in allProfiles / profileMap.
  • Updates the install-path tables in cli/README.md and docs/skillhub/{,en/}guide/cli.md, adds a cli/CHANGELOG.md entry, and extends test/unit/agents/profiles.test.ts for the new profile.

Validation

  • Backend tests passed (bun test: 561 pass, 0 fail)
  • Frontend typecheck/build passed (bun run typecheck, bun run build)
  • OpenAPI SDK regenerated or checked when API contracts changed (no API contract changes)
  • Smoke test run when relevant (built CLI resolves --agent zcode to ~/.zcode/skills and detects an existing installation there)

Commands run:

cd cli
bun install
bun run typecheck
bun test
bun run build
node dist/index.js list --agent zcode --registry <registry> --json
node dist/index.js install @global/skillhub-cli --version 2.0.2 --scope user --agent zcode --registry <registry> --json

Risk

  • User-facing impact: New --agent zcode choice and auto-detection of .zcode/skills directories; no change to existing agents or default behavior.
  • Deployment or migration impact: None.
  • Rollback approach: Revert the commit.

Notes

  • Related issue: none
  • Follow-up work: none
  • Docs or operator runbooks updated when behavior changed: yes (cli/README.md, docs/skillhub/guide/cli.md, docs/skillhub/en/guide/cli.md, cli/CHANGELOG.md)

@CLAassistant

CLAassistant commented Oct 2, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Add a first-class zcode profile so skills can be installed into ZCode's
skills directories with --agent zcode:

- project-level: <project>/.zcode/skills/
- user-level: ~/.zcode/skills/

The profile follows the existing makeProfile pattern with automatic
detection of both scopes, and is covered by unit tests. Docs tables and
the CLI changelog are updated accordingly.

Signed-off-by: twodogegg <971270272@qq.com>
@twodogegg
twodogegg force-pushed the feat/zcode-agent-profile branch from cea5f44 to 7e86caf Compare October 2, 2026 21:47
@FenjuFu

FenjuFu commented Oct 4, 2026

Copy link
Copy Markdown
Member

Thanks for adding the ZCode profile — the change follows the existing makeProfile pattern and updates both docs tables and the CHANGELOG, which is exactly what we need.

Two process items before we can merge:

  1. The DCO check is failing because the commit has no Signed-off-by line. Please run git commit --amend -s --no-edit && git push --force-with-lease.
  2. Please sign the CLA via the link in the CLA assistant comment above.

Could you also link ZCode's documentation for the skills directory locations (especially the user-level ~/.zcode/skills)? Once those are in place we'll approve the CI run and review.

@twodogegg

Copy link
Copy Markdown
Contributor Author

@FenjuFu Thanks for the review! Here are the official ZCode documentation references:

The current head commit, 7e86caf2ad5762d2c936ce244abe912831a2b0f6, already includes the Signed-off-by trailer, and both the DCO and license/cla checks are passing. The CLA assistant also confirms that all committers have signed.

The Security, PR CLI, and PR Tests workflows currently show action_required. Could you please approve the CI runs and proceed with the review? Thanks!

@FenjuFu FenjuFu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the links. ~/.zcode/skills/<skill-name>/SKILL.md is confirmed in ZCode's docs. I've approved the CI runs and they all pass; the change follows the existing makeProfile pattern and keeps both doc tables and the CHANGELOG in sync. LGTM.

@XiaoSeS
XiaoSeS merged commit dab10a4 into iflytek:main Oct 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants