Repository navigation
Conversation
parseIssueBody only matched ### headings, so hand-written issues using ## Problem / ## Proposed solution were routed to needs-info with every required section reported missing. Signed-off-by: FenjuFu <fufenjupku@gmail.com>
7 tasks done
Member
Author
|
Superseded by #916, which carries the same fix plus regression tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseIssueBodyin.github/scripts/issue-triage-lib.tsnow treats both##and###headings as section boundaries (/^#{2,3}\s+(.+)$/gm).###, but hand-written issues often use##. Those issues were reported as missing every required section and routed totriage/needs-infowith confidence 1/5, even when the content was complete (e.g. [Feature] Namespace 支持 24 小时单次邀请链接 #911, including after/retriage).Validation
Ran
analyzeIssueagainst the current body of #911, before and after the change, plus a form-style###body to confirm nothing changes for form issues:Risk
##headings get the same parsing as form issues./retriage.A
###sub-heading inside a##section now starts its own section. That matches how form-based bodies were already split, and the required-field checks only look up the top-level names (problem,proposed solution,summary, ...).Notes