fix(web): keep select poppers inside collision bounds - #755
Merged
Conversation
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
XiaoSeS
force-pushed
the
fix/select-popper-viewport-followup
branch
from
August 25, 2026 11:47
ac2cb2b to
b2d5a90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep shared Select popper content inside Radix collision bounds on small viewports.
Why
The previous shared Select fix added viewport-based max height, but the component still applied Tailwind translate utilities after Radix calculated the collision boundary. On short browser windows, that static transform could move the menu a few pixels outside the viewport.
This is visible in long Select menus such as the publish namespace picker.
How
sideOffset={4}.translate-*side transforms fromSelectContent.Testing
pnpm exec vitest run src/shared/ui/select.test.tspnpm run typecheckpnpm run lintImpact