fix(dashboard): remove encoding from slug params - #747
Conversation
The router handles parameter encoding automatically. Explicitly encoding the slug results in double-encoded characters in the URL. Signed-off-by: wurongjie <wurongjie@uniontech.com>
65f5b70 to
a7526b4
Compare
|
Correct fix — TanStack Router percent-encodes path params when it builds the URL, so the explicit |
|
Spot on – double‑encoding fixed. Verified with a Chinese‑slug skill: URL is clean, detail page renders fine. Ready to go, resolving. |
FenjuFu
left a comment
There was a problem hiding this comment.
Re-reviewed the one-line fix and the reported Chinese-slug click-through. TanStack Router owns path-param encoding, so passing the raw slug removes the double-encoding without changing route semantics. All remote checks, DCO, and CLA are green.
What
Remove explicit encoding from slug parameters in dashboard page.
Why
The router handles parameter encoding automatically. Explicitly encoding the slug results in double-encoded characters in the URL.
How
Remove the
encodeURIComponentcall when passing slug to router navigation.Testing
Impact