Skip to content

fix(web) 添加oidc的logo文件,配置oidc登录后图裂无logo太丑了 - #734

Open
qwn3213 wants to merge 2 commits into
iflytek:mainfrom
qwn3213:fix(web)oidc-logo
Open

fix(web) 添加oidc的logo文件,配置oidc登录后图裂无logo太丑了#734
qwn3213 wants to merge 2 commits into
iflytek:mainfrom
qwn3213:fix(web)oidc-logo

Conversation

@qwn3213

@qwn3213 qwn3213 commented Aug 19, 2026

Copy link
Copy Markdown
image 如图

@CLAassistant

CLAassistant commented Aug 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@FenjuFu

FenjuFu commented Aug 20, 2026

Copy link
Copy Markdown
Member

Thanks for adding the OIDC logo. One thing to double-check before this lands: the file is named oidc-loge.svg, which looks like a typo for oidc-logo.svg.

The other provider assets in web/public follow the {provider}-logo.svg convention (github-logo.svg, gitlab-logo.svg), so the login component almost certainly references oidc-logo.svg. If so, adding the file under the misspelled name won't actually fix the broken image — the <img src> would still 404. Could you confirm the filename exactly matches the src the OIDC login button uses, and rename to oidc-logo.svg if it follows the same convention? The SVG contents themselves look fine.

@qwn3213

qwn3213 commented Aug 20, 2026

Copy link
Copy Markdown
Author

Sorry, it was indeed a misnaming. It has been corrected.

@FenjuFu

FenjuFu commented Aug 22, 2026

Copy link
Copy Markdown
Member

Thanks — confirmed that the file is now correctly named web/public/oidc-logo.svg, so the filename issue is resolved.

The remaining blocker is DCO: both commits (c421e08a and 35488c6b) currently have no Signed-off-by trailer. Please add a matching sign-off to every commit (for example, rebase the branch with --signoff), update the branch with git push --force-with-lease, and request re-review once the DCO check is green.

Signed-off-by: qwn3213 <qwn3213@gmail.com>
@qwn3213
qwn3213 force-pushed the fix(web)oidc-logo branch from 35488c6 to 54f3b48 Compare August 24, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants