fix: deploy-server 시크릿 보간·로그 PII 제거#54
Merged
Merged
Conversation
- AZURE_CLIENT_ID 를 run 본문 보간 대신 env 로 받아 변수명만 검사 - az containerapp update 출력을 -o none 으로 억제(생성자 이메일·아웃바운드 IP 노출 차단) Closes #53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
전 레포 GitHub Actions 보안 감사 결과. 실제 평문 누출 없음(마스킹 정상). 마스킹 의존 패턴·로그 PII 제거.
변경
Check Azure secrets:${{ secrets.AZURE_CLIENT_ID }}를run:본문에 직접 보간하지 않고env:로 받아$AZURE_CLIENT_ID변수명으로만 빈값 검사(마스킹 전 렌더 파이프라인 평문 통과 차단).Deploy to Container Apps:az containerapp update ... -o none으로 응답 JSON 출력 억제 — 리소스 생성자 이메일(createdBy, PII)·ACA 아웃바운드 IP 가 공개 CI 로그에 남던 것 제거. 배포 성패는 종료코드로 판단.테스트
Closes #53