차례가 됐을 때 포커스 - #6
Conversation
- libs.versions.toml 파일에서 라이브러리 버전을 1.3.0에서 1.3.1로 업데이트 - TapTarget.kt 파일에 ExperimentalFoundationApi 추가 및 컴포즈 레이아웃 리팩토링 - App.kt 파일에서 레이아웃 컴포넌트 변경 및 의존성 추가로 UI 개선
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to automatically bring active tap targets into view using Compose's BringIntoViewRequester, along with a configuration option bringIntoViewEnabled to toggle this behavior. The example app has been updated to demonstrate this scrolling behavior. Feedback on the changes highlights an issue in TapTargetCoordinator where launching a coroutine using an external coroutineScope inside LaunchedEffect is an anti-pattern that can lead to cancellation issues; instead, the suspend function bringIntoView() should be called directly within the LaunchedEffect's own coroutine scope.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- TapTarget 컴포넌트 로직 개선 및 상태 관리 최적화 - Modifier.tapTarget 함수 시그니처 변경 및 기능 확장 - TapTargetDefinition 데이터 클래스 추가 및 속성 정의 개선
No description provided.