Feature/gidd dashboard - #133
Merged
Merged
Conversation
AdityaKhatri
force-pushed
the
feature/gidd-dashboard
branch
4 times, most recently
from
August 21, 2026 11:37
32a925d to
e6747a4
Compare
subinasr
force-pushed
the
feature/gidd-dashboard
branch
from
August 24, 2026 12:06
cc56a50 to
06885df
Compare
AdityaKhatri
force-pushed
the
feature/gidd-dashboard
branch
3 times, most recently
from
August 26, 2026 09:23
e3e4635 to
bfaa454
Compare
AdityaKhatri
requested changes
Aug 27, 2026
| @@ -0,0 +1,91 @@ | |||
| import { useMemo, useEffect } from 'react'; | |||
Contributor
There was a problem hiding this comment.
Move this component to where the slide itself and fetch it there.
Comment on lines
+96
to
+104
| {countries.map((country) => ( | ||
| <FigureAnalysisFetcher | ||
| key={country.iso3} | ||
| iso3={country.iso3} | ||
| year={year} | ||
| clientCode={clientCode} | ||
| onResults={handleResults} | ||
| /> | ||
| ))} |
Comment on lines
+96
to
+97
| const cOn = cause !== 'disaster'; | ||
| const dOn = cause !== 'conflict'; |
Comment on lines
+185
to
+190
| {pending ? ( | ||
| <Message pending compact /> | ||
| ) : ( | ||
| <ListView | ||
| className={styles.list} | ||
| data={rows} |
Contributor
There was a problem hiding this comment.
Use pending from ListView
Comment on lines
+1258
to
+1265
| <div className={styles.chartBlock}> | ||
| <Header | ||
| heading="Internal displacements" | ||
| headingClassName={styles.slideHeading} | ||
| headingSize="medium" | ||
| headingTooltip={flowDetails} | ||
| headingTooltipTitle="Internal displacements" | ||
| headingDescription={`New movements per year globally, ${domainForCharts[0]}–${domainForCharts[1]}`} |
Contributor
There was a problem hiding this comment.
Lets move this to separate component
tnagorra
reviewed
Aug 30, 2026
Comment on lines
+530
to
+533
| conflictNew: row.conflictNewDisplacementRounded ?? 0, | ||
| conflictTotal: totalRow?.conflictTotalDisplacementRounded ?? 0, | ||
| disasterNew: row.disasterNewDisplacementRounded ?? 0, | ||
| disasterTotal: totalRow?.disasterTotalDisplacementRounded ?? 0, |
Contributor
There was a problem hiding this comment.
conflictNew is not a good name to:
- "conflictNewDisplacement"
- "conflictTotalDispalcemnet"
- "disasterNewDisplacement"
- "disasterTotalDisplacement"
tnagorra
reviewed
Aug 30, 2026
| disasterTotalDisplacement | ||
| disasterTotalDisplacementRounded | ||
| # raw, for the combined value only: a total is summed before it is rounded | ||
| conflictNewDisplacement |
Contributor
There was a problem hiding this comment.
We shouldn't fetch non-rounded values at all.
The aggregations should be done in the server.
tnagorra
reviewed
Aug 30, 2026
tnagorra
reviewed
Aug 30, 2026
tnagorra
marked this pull request as ready for review
August 30, 2026 08:33
tnagorra
force-pushed
the
feature/gidd-dashboard
branch
from
August 30, 2026 08:34
2350ed1 to
c5b711e
Compare
tnagorra
reviewed
Aug 30, 2026
| { | ||
| cause, | ||
| iso3__in: countriesIso3, | ||
| violence_sub_type__in: violenceSubTypes, |
Contributor
There was a problem hiding this comment.
Why not pass hazard subtype?
tnagorra
reviewed
Aug 30, 2026
| : { | ||
| cause, | ||
| iso3__in: countriesIso3, | ||
| violence_sub_type__in: violenceSubTypes, |
Contributor
There was a problem hiding this comment.
Why not pass hazard subtype?
tnagorra
approved these changes
Aug 30, 2026
* Fix description of each slide
- IDU: clicking a map bubble opens its popup without changing the active focus - IDU: slide list items (country/event/trigger) toggle focus on/off on click - IDU: add "Focus event on map" and name the active focus in the pill - IDU: pad focus/zoom bounds so markers aren't at the edge - GIDD: thicken the ranking and breakdown bars - GIDD: refine the type-breakdown headings and description
…dths - GIDD tables: pin the header sort icon and wrap/clamp long header labels - GIDD filters: fixed width so the row doesn't shift when a value/clear icon changes - minor label and column-heading tweaks
tnagorra
force-pushed
the
feature/gidd-dashboard
branch
from
August 30, 2026 09:07
c5b711e to
ed39601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on:
idmc-labs/helix-server#799
Changes
This PR doesn't introduce any:
console.logmeant for debugging