Migrating to bevy 0.19. by martinfrances107 · Pull Request #128 · idanarye/bevy-tnua

martinfrances107 · 2026-06-20T08:02:25Z

Initial version just changing version in various Cargo.toml files.

martinfrances107 · 2026-06-20T08:06:11Z

This does not yet compile .. I am working through the migration guide

This requires the include of two bevy subcrates + "system_font_discovery", + "bevy_pbr",

martinfrances107 · 2026-06-20T10:03:53Z

Fixed some compile errors, more to follow

2) DirecionLight - shadows_enabled: true, + shadows_maps_enabled: true, 3) SceneRoot - cmd.insert(SceneRoot(asset_server.load("player.glb#Scene0"))); + cmd.insert(WorldAsserRoot(asset_server.load("player.glb#Scene0"))); 4) Many crate migrated to latest 5) bevy_rapier2d bevy_rapier3d bevy_egui egui_plot egui_extra 6) added bevy_ecs

martinfrances107 · 2026-06-20T16:37:50Z

I think I am the point where I need to stop and migrate avain3d

the current verison of avian3d is pulling in bevy 0.18 and causing too many conflicts
( this escosyem is so inter-connected it always takes a few weeks for things to shake out )

martinfrances107 · 2026-06-20T16:41:38Z

Not my work but the avian migration this is nearly complete

avianphysics/avian#991

idanarye · 2026-06-20T20:30:17Z

This is why I never even start upgrading this crate before either Avian or Rapier upgrade to the new Bevy.

martinfrances107 · 2026-06-21T06:17:56Z

avain3d/avain2d has pushed the bevy migration into main

So I have placed a "DO NOT COMMIT" hot fix to use the main branch
This removes much of the compile error shown by cargo test

This allowed me to see more fixes here.

martinfrances107 · 2026-06-21T06:47:11Z

Progress - cargo test now passes.

I am putting in pause in here

Wait for avain2d/3d to publish an release, so we can removed the hot fix.
Changelog needs to be updated etc

…f32().

martinfrances107 · 2026-06-21T08:19:08Z

Just reviewing my own work - stripping the patch back to what is needed.

removed unwanted calls to .into()

martinfrances107 · 2026-06-21T09:02:13Z

avian2d/avian3d has now published 0.7 removed hot fix.

I am currently focusing on the Changelog

martinfrances107 · 2026-06-21T09:25:36Z

I am still working on this, but

@idanarye -- would you like me to roll up / merge these multiple changes up into a single commit ?

martinfrances107 · 2026-06-21T12:19:06Z

I think this is functionally complete...

After looking the changes to the various changelogs are best handled separately as part of the release cycle.

I don't thing this involved any change to the public API - So have nothing to add to the MIGRATION-GUIDES

So I think this PR is complete and ready for review? I will jump on anything that comes up.

idanarye · 2026-06-21T15:49:40Z

@martinfrances107 I prefer a single commit, but I won't insist on it. Do merge master (or, if you squash them, rebase on it) to obtain #130 so I can run the CI on it.

I'll try to review it later.

Picking up changes to .github/workflow/ci.yml Needed because Bevy always moved to the lastest rust toolchain for performance.

idanarye

Lots of these changes seem unrelated. I believe you did some them because of warnings you received when building with no physics backend (because you started before Avian was upgraded)?

Also note that the CI is red.

idanarye · 2026-06-21T22:44:27Z

@@ -1,5 +1,6 @@
-use avian2d::prelude::*;


Why did you remove the prelude import? This is the usual way to do import these things in Rust.

idanarye · 2026-06-21T22:48:16Z

@@ -1,5 +1,6 @@
-use avian2d::prelude::*;
-use bevy::{ecs::system::SystemParam, prelude::*};
+use crate::{Collider, Position, Rotation};


Wait what? These are Avian types - why are you importing them from crate?

idanarye · 2026-06-21T22:51:59Z

                1,
                &[
-                    ("Point", |mut cmd| {
+                    ("Point", |_cmd| {


Uh... no? cmd is used inside the closure body. I assume, when you try to build with neither physics backend --features flag the compiler will complain - but the demo would be useless when built that way...

idanarye · 2026-06-21T22:54:02Z

        #[allow(unused)] radius: Float,
    ) -> EntityCommands<'_> {
-        let font = self.asset_server.load("FiraSans-Bold.ttf");
+        let font = FontSource::Handle(self.asset_server.load("FiraSans-Bold.ttf"));


The migration guide recommends using .into() here.

idanarye · 2026-06-21T22:58:56Z

 use tuning::UiTunable;

-#[derive(SystemSet, Clone, PartialEq, Eq, Debug, Hash)]
+#[derive(ScheduleLabel, SystemSet, Clone, PartialEq, Eq, Debug, Hash)]


Why? It's not used as a schedule label.

You are only importing ScheduleLabel when the egui feature flag is on, but using it even when it's off. This will fail to build without that flag.

idanarye · 2026-06-21T23:00:25Z

 clap = { version = "^4", features = ["derive"] }
 ordered-float = "5.0.0"
 serde = { version = "1.0.228", features = ["derive"] }
+bevy_ecs = "0.19.0"


Please don't. When you need to import something from bevy_ecs (and you don't) just use the bevy::ecs re-export.

idanarye · 2026-06-22T18:56:08Z

I don't want to keep delaying the upgrade, so I'm going to just merge and fix these thing myself.

martinfrances107 · 2026-06-23T07:23:17Z

Thanks for the careful review.. I agree with everything.

I have learned a lot

Migrating to bevy 0.19.

9b1774f

martinfrances107 mentioned this pull request Jun 20, 2026

Verify needed adjustments for bevy 0.19 #127

Open

Migration to bevy 0.19 - Fixed obvious compilation errors

df6425c

This requires the include of two bevy subcrates + "system_font_discovery", + "bevy_pbr",

martinfrances107 added 2 commits June 21, 2026 07:25

Hot fixing avian2d/3d, and more migration.

37e384d

cargo test, now passes (migration to bevy 0.19)

3eaf7da

Migration to bevy 0.19 - removed calls to .into(), restored calls to …

f69bdde

…f32().

avian2d/3d removed hot patch now using avian2d/3d 0.7.

a774d5f

Merge branch 'main' into MigrateBevy0p19

5ea4313

Picking up changes to .github/workflow/ci.yml Needed because Bevy always moved to the lastest rust toolchain for performance.

idanarye requested changes Jun 21, 2026

View reviewed changes

idanarye merged commit 5b2b5ac into idanarye:main Jun 22, 2026
3 of 8 checks passed

martinfrances107 deleted the MigrateBevy0p19 branch June 23, 2026 07:23

Conversation

martinfrances107 commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martinfrances107 commented Jun 20, 2026

Uh oh!

martinfrances107 commented Jun 20, 2026

Uh oh!

martinfrances107 commented Jun 20, 2026

Uh oh!

martinfrances107 commented Jun 20, 2026

Uh oh!

idanarye commented Jun 20, 2026

Uh oh!

martinfrances107 commented Jun 21, 2026

Uh oh!

martinfrances107 commented Jun 21, 2026

Uh oh!

martinfrances107 commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martinfrances107 commented Jun 21, 2026

Uh oh!

martinfrances107 commented Jun 21, 2026

Uh oh!

martinfrances107 commented Jun 21, 2026

Uh oh!

idanarye commented Jun 21, 2026

Uh oh!

idanarye left a comment

Choose a reason for hiding this comment

Uh oh!

idanarye Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

idanarye Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

idanarye Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

idanarye Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

idanarye Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

idanarye Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

idanarye commented Jun 22, 2026

Uh oh!

Uh oh!

martinfrances107 commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

martinfrances107 commented Jun 20, 2026 •

edited

Loading

martinfrances107 commented Jun 21, 2026 •

edited

Loading