Fix Joker Rarity Formula#3
Open
spencers145 wants to merge 1 commit into
Open
Conversation
Owner
|
Oh, this has made me realize I've not actually pushed my most recent change! I've indeed noticed the formula was wrong, so I'd opted to change it. It might be, however, that your approach is more effective, so I'll have a look at comparing the two! Thanks a lot for contributing, regardless, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, nice mod! I was looking for something like this to help with my own personal modpack making.
Changed the
joker_rateformula to essentiallyjoker_rate = everything_else_total_rate * desired_joker_percentage / (100% - desired_joker_percentage).I verified experimentally that it works. Setting joker rarity to 58% before got me ~64% jokers across 100 rerolls, now it gets me ~57% jokers.
The
1.00001should be1mathematically, but if joker_rate is set to 100% I don't want a divide by zero, so I added a negligible amount to stop that quick and easy.