Fix async void exception handling in command execute methods#3882
Open
Moli13337 wants to merge 1 commit into
Open
Fix async void exception handling in command execute methods#3882Moli13337 wants to merge 1 commit into
Moli13337 wants to merge 1 commit into
Conversation
async void methods in command Execute handlers can cause unhandled exceptions that crash the application. This fix extracts the async logic into Task-returning methods and uses HandleExceptions() to ensure exceptions are properly caught and routed to GlobalExceptionHandler, matching the fire-and-forget pattern used throughout the project. Assisted-by: Claude:claude-opus-4-8:Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes critical exception handling issues in command
Executemethods whereasync voidwas used, causing unhandled exceptions that could crash the application.Changes
OpenCommand.ExecuteandSaveCommand.ExecuteLoadDependencies.ExecuteWhat was fixed?
Previously, these methods used
async voidwhich:Now they use the project's standard fire-and-forget pattern:
void Execute(maintains interface compatibility)Task ExecuteAsyncHandleExceptions()to route errors toGlobalExceptionHandler