Jitter plugins#1027
Draft
andybak wants to merge 7 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Lua scripting hook intended to let plugins override brush color jitter behavior by running a “JitterScript” instead of the built-in HSV jitter logic.
Changes:
- Add
LuaApiCategory.JitterScriptand aJitterScriptsEnabledflag inLuaManager. - Add
LuaManager.CallActiveJitterScript(fnName, currentColor)to invoke the active jitter script and convert its return value toColor. - Update
PointerManager.CalculateJitteredColorto delegate jitter computation to Lua when enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Assets/Scripts/PointerManager.cs | Routes color jitter calculation through Lua when JitterScriptsEnabled is on. |
| Assets/Scripts/API/Lua/LuaManager.cs | Adds the new jitter category, enable flag, and the API surface for calling the active jitter script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1982
to
+1985
| if (LuaManager.Instance.JitterScriptsEnabled) | ||
| { | ||
| return LuaManager.Instance.CallActiveJitterScript("main", currentColor); | ||
| } |
Comment on lines
128
to
+132
| [NonSerialized] public bool PointerScriptsEnabled; | ||
| [NonSerialized] public bool VisualizerScriptingEnabled; | ||
| [NonSerialized] public bool BackgroundScriptsEnabled; | ||
| [NonSerialized] public bool JitterScriptsEnabled; | ||
|
|
Comment on lines
+776
to
+782
| public Color CallActiveJitterScript(string fnName, Color currentColor) | ||
| { | ||
| var script = GetActiveScript(LuaApiCategory.JitterScript); | ||
| script.Globals.Set("_currentColor", DynValue.FromObject(script, currentColor)); | ||
| DynValue result = _CallScript(script, fnName); | ||
| return result.ToObject<Color>(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.