Fix search window getting stuck when hidden during the show animation#168
Open
davidmrc6 wants to merge 1 commit into
Open
Fix search window getting stuck when hidden during the show animation#168davidmrc6 wants to merge 1 commit into
davidmrc6 wants to merge 1 commit into
Conversation
9b5fe2d to
91f7014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hide()did not cancel the pending_animSeqshow-animation timer scheduled byshow(). When the window is hidden within the ~100 ms animation window, the orphaned timer fires after_release_ui()/_remove_events()have run, re-executing_layout()(which sets_visible = true) and re-easing the now-empty container back to opacity 255. The search box gets stuck on screen, unresponsive, with the search entry removed (placeholder gone) and no key handlers, and can only be recovered by reloading the extension (#146)Fix: cancel
_animSeqat the top ofhide(), mirroring the guard inshow().