Fix race condition for Paragraph and Editor in the renderer#2886
Closed
srussvoll wants to merge 1 commit into
Closed
Fix race condition for Paragraph and Editor in the renderer#2886srussvoll wants to merge 1 commit into
Paragraph and Editor in the renderer#2886srussvoll wants to merge 1 commit into
Conversation
…derer to support pipelined rendering.
Paragraph and Editor to the ren…Paragraph and Editor in the renderer
Member
|
This is planned, but it's unfortunately not as easy as cloning Specifically, iced/graphics/src/text/editor.rs Lines 265 to 267 in 41e69b0 We need to address those first while making sure that for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on the
bevy_icedplugin for Bevy that integrates Iced into Bevy:Since Bevy is using pipelined rendering and Iced assumes non-pipelined rendering, some things don't work. For instance, when typing into a text input widget, the text will often disappear for a frame when a letter is typed resulting in blinking, and is reported in #2318. The issue is that there is a race between the renderer reading the weakly referenced text and the destroying of that text, and is described in more detail here: #2670 (comment). I started a thread in Discord to discuss this problem more generically.
This PR fixes the race condition that causes the flashing text.
The following PR is also required to get
bevy_icedto work with the main branch of iced:finishandrecallmethods toiced_wgpu::Renderer#2693