Fix database dialog trigger and Windows MinGW workflow - #443
Open
YBronst wants to merge 17 commits into
Open
Conversation
Fix qt_tools parameter format in windows-mingw.yml Correct the syntax of the tools parameter for jurplel/install-qt-action. The modern aqt tool expects two comma-separated parameters (`tool_name,tool_variant`) instead of three (`tool_name,version,tool_variant`). Passing three parameters causes aqt to fail with an "unrecognized arguments" error.
1. Correct the tools format in `.github/workflows/windows-mingw.yml` to remove the outdated version string from `qt_tools` to prevent `aqt` argument errors. 2. Remove the early `return;` statement from `MainWindow::on_actionDatabase_triggered()` in `src/mainwindow.cpp` to ensure the local database dialog opens after the template message box is closed.
…66115490988 Fix database dialog trigger and Windows MinGW workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🇬🇧 Release Notes (English)
What's New in this Release:
🛠 Fixed Windows (MinGW) CI Build
windows-mingw.yml).toolsparameter ofinstall-qt-action.aqt: error: unrecognized arguments),allowing automated builds to finish successfully.
📂 Fixed Intel CPU Database Dialog Trigger
return;statement inMainWindow::on_actionDatabase_triggered().