Skip to content

[patch] remove ibm_entitlement_key from Tekton param flow and source from secrets#397

Open
jigneshchauhan2001 wants to merge 4 commits into
stablefrom
fix-secrets
Open

[patch] remove ibm_entitlement_key from Tekton param flow and source from secrets#397
jigneshchauhan2001 wants to merge 4 commits into
stablefrom
fix-secrets

Conversation

@jigneshchauhan2001

@jigneshchauhan2001 jigneshchauhan2001 commented Jun 19, 2026

Copy link
Copy Markdown

Summary

ibm_entitlement_key was appearing as plaintext in pod environment variables and was being passed through the MAS install PipelineRun into pod specs.
This change removes ibm_entitlement_key from the Tekton parameter flow under /cli/tekton/src and updates affected task pods to read IBM_ENTITLEMENT_KEY from Kubernetes secret pipeline-additional-configs.
It also applies the SLS speific-fix in /cli/tekton/src/tasks/dependencies/sls.yml.j2 so IBM_ENTITLEMENT_KEY is not injected into the SLS pod for newer SLS channel paths (sls_channel > 3.7.0).

Changes

ibm_entitlement_key moved to Secrets

  • replaced task pod env usage of $(params.ibm_entitlement_key) with valueFrom.secretKeyRef in affected task templates under:
  • removed ibm_entitlement_key Tekton param wiring from affected pipeline/taskdef templates under:
  • removed shared param definitions where no longer needed under:

SLS fix:

This change ensures:

  • the entitlement key is no longer exposed through Tekton params
  • affected pods read the key from Kubernetes Secret
  • SLS no longer receives the entitlement env in the newer channel path

Validation

Validation details are attached in Validations.docx
Which contains UI and CLI validation confirmed:

  • PipelineRuns do not contain ibm_entitlement_key
  • secret pipeline-additional-configs contains IBM_ENTITLEMENT_KEY
  • non-SLS install pods use valueFrom.secretKeyRef
  • SLS pod does not contain IBM_ENTITLEMENT_KEY in the validated newer-channel path
  • non-SLS pod YAML does not contain ibm_entitlement_key

Validated on Fyre OCP cluster:

  • install completed successfully
  • fvt-core completed successfully
  • fvt-sls completed successfully
  • fvt-manage completed successfully

FVT dashboard link:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant