[patch] remove ibm_entitlement_key from Tekton param flow and source from secrets#397
Open
jigneshchauhan2001 wants to merge 4 commits into
Open
[patch] remove ibm_entitlement_key from Tekton param flow and source from secrets#397jigneshchauhan2001 wants to merge 4 commits into
jigneshchauhan2001 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ibm_entitlement_keywas appearing as plaintext in pod environment variables and was being passed through the MAS install PipelineRun into pod specs.This change removes
ibm_entitlement_keyfrom the Tekton parameter flow under /cli/tekton/src and updates affected task pods to readIBM_ENTITLEMENT_KEYfrom Kubernetes secretpipeline-additional-configs.It also applies the SLS speific-fix in /cli/tekton/src/tasks/dependencies/sls.yml.j2 so
IBM_ENTITLEMENT_KEYis not injected into the SLS pod for newer SLS channel paths (sls_channel > 3.7.0).Changes
ibm_entitlement_key moved to Secrets
$(params.ibm_entitlement_key)withvalueFrom.secretKeyRefin affected task templates under:ibm_entitlement_keyTekton param wiring from affected pipeline/taskdef templates under:SLS fix:
- /cli/tekton/src/tasks/dependencies/sls.yml.j2
IBM_ENTITLEMENT_KEYwhensls_channel > 3.7.0This change ensures:
Validation
Validation details are attached in Validations.docx
Which contains UI and CLI validation confirmed:
ibm_entitlement_keypipeline-additional-configscontainsIBM_ENTITLEMENT_KEYvalueFrom.secretKeyRefIBM_ENTITLEMENT_KEYin the validated newer-channel pathibm_entitlement_keyValidated on Fyre OCP cluster:
fvt-corecompleted successfullyfvt-slscompleted successfullyfvt-managecompleted successfullyFVT dashboard link: