fix(tauri): resolve oneshot in iOS open_external_url (unblocks iOS build) - #205
Open
sonegillis1 wants to merge 1 commit into
Open
fix(tauri): resolve oneshot in iOS open_external_url (unblocks iOS build)#205sonegillis1 wants to merge 1 commit into
sonegillis1 wants to merge 1 commit into
Conversation
…ild) The iOS-only path in open_external_url called `oneshot::channel()` with no `oneshot` in scope, so `cargo build --target aarch64-apple-ios` failed with E0433 (unresolved module `oneshot`) plus two downstream E0282s. This has been broken on main since the code was written — iOS isn't built in CI (only the macOS DMG is), so it went unnoticed. tokio (features = ["full"]) is already a dependency, so qualify it as `tokio::sync::oneshot::channel()`. Verified: cargo check --target aarch64-apple-ios now compiles. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cargo tauri ios build(targetaarch64-apple-ios) fails to compilesrc-tauri/src/lib.rs:The iOS-only branch of
open_external_urlusesoneshot::channel()but nothing bringsoneshotinto scope. This has been broken onmainsince the code was written — iOS isn't built in CI (only the macOS DMG is), so it never got caught.Fix
tokio(withfeatures = ["full"]) is already a dependency, so qualify it:tokio::sync::oneshot'sReceiver::awaitreturnsResult<T, RecvError>, which the existing.unwrap_or_else(|_| Err(...))already flattens correctly — no other changes needed.Verification
cargo check --target aarch64-apple-ios --lib→ Finished (0 errors). Localmake tauri-ios-buildthen archives + uploads to App Store Connect successfully.🤖 Generated with Claude Code