feat(sql): add delete() method to SQLBackend#11992
Open
jsouzadasilva wants to merge 3 commits into
Open
Conversation
Add conditional row deletion via `delete(name, where, database=None)` to SQLBackend, following the existing insert/upsert patterns. The `where` parameter is required — passing None raises IbisInputError directing users to truncate_table() instead. BigQuery override handles catalog/db resolution matching the insert/upsert pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dtran-im
reviewed
Apr 15, 2026
dtran-im
reviewed
Apr 15, 2026
jsouzadasilva
commented
Apr 15, 2026
dtran-im
reviewed
Apr 15, 2026
dtran-im
reviewed
Apr 15, 2026
dtran-im
reviewed
Apr 15, 2026
dtran-im
reviewed
Apr 15, 2026
Contributor
|
@cpcloud Hello again. Wondering if you would approve the full test suite to run on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue: #11205.
Adds a
delete()method toSQLBackendfor conditionally removing rows from tables, following the establishedinsert()/upsert()patterns. Thewhereparameter is required — passingNoneraisesIbisInputErrordirecting users totruncate_table()instead. Includes a BigQuery-specific override for catalog/database resolution matching the existinginsert/upsertpattern.The API design look like this:
We've tested the BigQuery
deletelocally against our GCP project and BigQuery dataset, using a simple python script. Here's a summary of the tests run: