fix(share): include referenced choreographers in program share bundle so received dances keep author attribution (#412)

[ibanner56]

The bug (#412)

Sharing a program via the OS share sheet (AirDrop, etc.) produced a .ccshare bundle whose dances kept their authorIds but whose archive omitted the referenced choreographer records (buildProgramShareBundle left choreographers empty). User-visible symptom: a received shared dance imported with no choreographer / author attribution.

This is distinct from the already-fixed #410 (slots not resolving to dances): here the dance resolved fine but showed no choreographer.

Root cause — two sides

Send side omitted the choreographers entirely.

Receive side could not have honored them anyway: GenericJsonAdapter re-serialized each dance into a single-dance archive without choreographers, so parse produced a draft with the sender's raw authorIds but empty authorNames. ImportPipeline.commit then kept those raw ids, which reference choreographer rows the receiver never creates — failing the dance_authors foreign key (PRAGMA foreign_keys = ON) and dropping the dance. This was a pre-existing, production-affecting bug that also broke the manual "Caller's Compendium JSON" import of any authored dance onto a device lacking those exact ids.

Both fixes are required for the program-share round-trip, so they ship together in this one atomic PR.

The fix

Send side (app) — buildProgramShareBundle collects the DISTINCT choreographers referenced by the bundled dances' authorIds (deduped by id, stable first-seen order, unresolved id skipped / never fatal) via a new injected choreographerFor lookup, and embeds only those. Each is sanitized first — email/location cleared per the Choreographer privacy contract — so the shared file leaks no private contact data (name/website/notes/deceased preserved). Threaded through ProgramExportMenu and both screen call sites; a choreographersById map was added to CollectionData.

Receive side (core) — GenericJsonAdapter now captures the archive's choreographers during discover, embeds the ones a dance references into its self-contained single-dance payload, and populates StructuredDraft.authorNames (in authorIds order, blanks/unresolved dropped). The existing pipeline name-resolution matches or creates the choreographer row and rewrites authorIds to the receiver's own ids — no FK failure. commit's author logic is untouched. Full-DB restore uses a separate path (archive_service upserts choreographers directly) and is unaffected.

End-to-end verification

A round-trip test builds a bundle from an authored dance, then imports it on a fresh CompendiumArchiveImporter over the real, FK-enforced database: the dance imports, the program slot resolves (no placeholder), the resolved choreographer name matches the sender, and email/location are null.

OWASP / untrusted input

The received archive stays untrusted — no ArchiveIntakeService validation relaxed (size cap, UTF-8, well-formed-archive, forward-schema refusal, never-throw). Choreographer creation now driven by the bundle flows through the same validated decode + parameterized-drift path the manual import already crosses (no new sink): names are data-only, blank/whitespace names dropped, rows bounded by dances×authors under the existing 25 MiB intake cap and deduped by normalized name.

Tests

• Send side: referenced-only, dedupe-once, no-authors, unresolved-id skipped, email/location stripped.
• Adapter-level class fix: author-name recovery from payload choreographers; commit creates/points-at the receiver's row with no FK error; reuse-by-name (no duplicate).
• End-to-end program-share round-trip: on the real FK-enforced DB — dance imports, slot resolves, author name matches, email/location null.

Gates

• fvm dart format . — clean
• fvm flutter analyze (core + app) — 0 issues
• core fvm dart test — 1798 passed, 4 skipped (pre-existing)
• app fvm flutter test — 1642 passed

Refs #412. Share lineage #298.

[Copilot]

Pull request overview

Fixes program-share/import author attribution by ensuring referenced choreographers are included in the shared archive and that the receive-side JSON adapter carries those choreographer names through to the import pipeline so author IDs can be resolved/created safely.

Changes:

• App share-bundle builder now embeds only the choreographers referenced by bundled dances (with private contact fields stripped).
• Core GenericJsonAdapter now preserves referenced choreographers in single-dance payloads and populates StructuredDraft.authorNames from payload choreographers.
• Adds adapter-level, send-side, and end-to-end share/receive tests (including FK-enforced DB round-trip).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/compendium_core/test/imports/generic_json_adapter_test.dart	Adds regression tests ensuring author names are recovered and commits create/reuse choreographer rows without FK failures.
packages/compendium_core/lib/src/imports/generic_json_adapter.dart	Captures archive choreographers during discover, embeds referenced choreographers in fetch payloads, and derives authorNames during parse.
app/test/program_share_bundle_test.dart	Expands tests to cover choreographer inclusion, privacy stripping, and full end-to-end receiver attribution behavior.
app/lib/src/widgets/program_export_menu.dart	Threads a choreographerFor resolver into the “Share (program + dances)” action.
app/lib/src/search/collection_data.dart	Adds a choreographersById map to support share/export author resolution.
app/lib/src/screens/program_summary_screen.dart	Supplies choreographerFor from loaded collection data to the export menu.
app/lib/src/screens/program_editor_screen.dart	Supplies choreographerFor from loaded collection data to the export menu.
app/lib/src/export/program_share_bundle.dart	Builds share bundles that include only referenced choreographers and sanitizes private fields before encoding.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.