Implement custom editor command helpers - #6091
Merged
Merged
Conversation
Added custom helper functions for editor commands.
12joan
reviewed
Aug 4, 2026
Co-authored-by: Joe Anderson <4272090+12joan@users.noreply.github.com>
|
bye-shuvo
commented
Aug 19, 2026
bye-shuvo
left a comment
Contributor
Author
There was a problem hiding this comment.
Maintained zero ; in the code supporting slate standard
Contributor
Author
|
Thanks for the clarifications.
…On Wed, Aug 19, 2026 at 2:29 AM Dylan Schiemann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/walkthroughs/05-executing-commands.md
<#6091 (comment)>
:
> @@ -244,4 +244,97 @@ const App = () => {
That's the benefit of extracting the logic.
+We can make the code more modular by separating the logic within a few helper functions using the below code:
While I use semicolons in all of my code, we don't in Slate, so you should
update to the current Slate standard and then we can merge this. Thanks.
—
Reply to this email directly, view it on GitHub
<#6091?email_source=notifications&email_token=BFE66OEG6MR3VUOE76UTBST5KS4D3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJWGU2DOMJXGYZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#discussion_r3807680725>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFE66OHVJL64PJCKJFTMMTL5KS4D3AVCNFSNUABEKJSXA33TNF2G64TZHM3DCNBRGIYDEMR3JFZXG5LFHM2TANJXG4ZTIMJRGWQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BFE66OAVJ6K4UGUQKIVN6QD5KS4D3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJWGU2DOMJXGYZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BFE66OA2D47KF6MOUFSZ23L5KS4D3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJWGU2DOMJXGYZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added custom helper functions for editor commands.
Description
A modular approach to use the custom editor functionalities for any of the blocks or marks of the editor.
Example
In the previous doc it only shows a custom method for each of the marks. In the added doc it shows a way of implementing modular marks.