Skip to content

Support getting slice fields from environment #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zalenskivolt wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support getting slice fields from environment #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions enviper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"reflect"
"strings"

"github.com/mitchellh/mapstructure"
"github.com/go-viper/mapstructure/v2"

"github.com/spf13/viper"
)
Expand Down Expand Up @@ -75,7 +75,8 @@ func (e *Enviper) bindEnvs(in interface{}, prev ...string) {
ifv = ifv.Elem()
}

switch ifv.Kind() {
fieldKind := ifv.Kind()
switch fieldKind {
case reflect.Struct:
for i := 0; i < ifv.NumField(); i++ {
fv := ifv.Field(i)
Expand Down Expand Up @@ -120,9 +121,13 @@ func (e *Enviper) bindEnvs(in interface{}, prev ...string) {
}
}
default:
env := strings.Join(prev, ".")
key := strings.Join(prev, ".")
// Viper.BindEnv will never return error
// because env is always non empty string
_ = e.Viper.BindEnv(env)
// because key is always non empty string
if fieldKind != reflect.Slice {
_ = e.Viper.BindEnv(key)
} else {
_ = e.Viper.BindEnvSliceValue(key)
}
}
}