feat(style): move style.point.model to its own category: 'model' - #2808
Open
ftoromanoff wants to merge 3 commits into
Open
feat(style): move style.point.model to its own category: 'model'#2808ftoromanoff wants to merge 3 commits into
ftoromanoff wants to merge 3 commits into
Conversation
ftoromanoff
force-pushed
the
feat/modelStyle
branch
2 times, most recently
from
July 1, 2026 09:08
af3c3a0 to
c1ca507
Compare
ftoromanoff
changed the title
gchoqueux
reviewed
Jul 1, 2026
ftoromanoff
force-pushed
the
feat/modelStyle
branch
2 times, most recently
from
July 7, 2026 13:16
96261e2 to
fe81a26
Compare
ftoromanoff
force-pushed
the
feat/modelStyle
branch
5 times, most recently
from
July 28, 2026 12:12
ab49d98 to
1db5332
Compare
ftoromanoff
marked this pull request as ready for review
July 28, 2026 12:24
ftoromanoff
force-pushed
the
feat/modelStyle
branch
10 times, most recently
from
July 30, 2026 09:58
ba7f2da to
fc81a0b
Compare
gchoqueux
reviewed
Aug 4, 2026
Comment on lines
+735
to
+757
| const styleModel = style.model; | ||
| const count = geometries.length; | ||
| const instancedMesh = new THREE.InstancedMesh(mesh.geometry, mesh.material, count); | ||
| let index = 0; | ||
| for (let i = 0; i < count * 3; i += 3) { | ||
| const mat = new THREE.Matrix4(); | ||
| mat.setPosition(ptsIn[i], ptsIn[i + 1], ptsIn[i + 2]); | ||
| instancedMesh.setMatrixAt(index, mat); | ||
| index++; | ||
|
|
||
| for (let j = 0; j < count; j += 1) { | ||
| context.setGeometry(geometries[j]); | ||
| scale.set(1, 1, 1); | ||
| if (styleModel.size) { | ||
| scale.set( | ||
| styleModel.size.x / modelSize.x, | ||
| styleModel.size.y / modelSize.y, | ||
| styleModel.size.z / modelSize.z, | ||
| ); | ||
| } | ||
|
|
||
| let headingRad = 0; | ||
| if (styleModel.heading) { | ||
| headingRad = styleModel.heading * THREE.MathUtils.DEG2RAD; | ||
| } | ||
| mat.makeRotationZ(-headingRad); | ||
| mat.setPosition(ptsIn[j * 3], ptsIn[j * 3 + 1], ptsIn[j * 3 + 2]); | ||
| mat.scale(scale.multiplyScalar(styleModel.scale)); | ||
| instancedMesh.setMatrixAt(j, mat); |
Contributor
There was a problem hiding this comment.
Could you use Vector3 methods to simplify your code
Contributor
Author
There was a problem hiding this comment.
done
scale.set(1, 1, 1) => scale.setScalar(1)
scale.set(x1/V.x, y1/V.y, z1/V.z) => scale.divide(V)
Comment on lines
+180
to
+181
| model: { | ||
| object: model, |
Contributor
There was a problem hiding this comment.
could you rename var model to object to have model: { object,
| const modelObject = style.model.object; | ||
|
|
||
| // orientation of the model following up and north properties. | ||
| quaternion.setFromUnitVectors(style.model.up, zVect); |
Contributor
There was a problem hiding this comment.
It's possible to use Object3D.up ?
Contributor
Author
There was a problem hiding this comment.
I tried it to use with Object3D.lookAt(). But it has no direct impact to orient the object.
Comment on lines
+782
to
+787
| const northWithRotation = style.model.north.applyQuaternion(quaternion.clone().conjugate()); | ||
| const angletoNorth = northWithRotation.angleTo(yVect); | ||
| quaternionY.setFromAxisAngle(yVect, angletoNorth); | ||
| quaternion.multiply(quaternionY); | ||
|
|
||
| modelObject.setRotationFromQuaternion(quaternion); |
Contributor
There was a problem hiding this comment.
This part seems complex; we could first orient the Z-axis locally toward the north, and then calculate the quaternion needed to orient the Z-axis in global space.
Contributor
Author
There was a problem hiding this comment.
As we will need to calculate the size of the model object in the world space (using the bbox) we need the model oriented in the global space.
ftoromanoff
force-pushed
the
feat/modelStyle
branch
4 times, most recently
from
August 5, 2026 14:49
19e65ef to
99029ea
Compare
ftoromanoff
force-pushed
the
feat/modelStyle
branch
from
August 5, 2026 15:21
99029ea to
ebe3491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, to instanciate several object 3D at different position, the associated style is the style category 'point' with the parameter 'object'.
The use of extra parameter as 'orientation', 'size', 'scale' to cite a few is currently limited. That's the reason why I propose to add a new style category 'model' with it's own parameter. (As it's done for text and icon).