Skip to content

Refacto Source methods - #2747

Merged
gchoqueux merged 3 commits into
iTowns:masterfrom
gchoqueux:refacto/source_hasdata
May 20, 2026
Merged

Refacto Source methods#2747
gchoqueux merged 3 commits into
iTowns:masterfrom
gchoqueux:refacto/source_hasdata

Conversation

@gchoqueux

Copy link
Copy Markdown
Contributor

Description

  • Simplify source methods for checking data availability within an extent or tile.
  • Add a TileMatrixSetLimits class to handle tile boundaries per zoom level, including global extent and intersection constraints.

Motivation and Context

@gchoqueux
gchoqueux force-pushed the refacto/source_hasdata branch from 23ee376 to 763e72f Compare April 15, 2026 13:05
@gchoqueux gchoqueux changed the title Refacto source Refacto Source methods Apr 15, 2026
@gchoqueux
gchoqueux force-pushed the refacto/source_hasdata branch from 763e72f to 8be665f Compare April 16, 2026 06:52
@Desplandis
Desplandis requested a review from jailln April 17, 2026 07:32
@gchoqueux
gchoqueux force-pushed the refacto/source_hasdata branch 3 times, most recently from 5f1803e to d1f0d91 Compare April 23, 2026 12:32
@jailln
jailln requested review from Neptilo and removed request for jailln April 27, 2026 15:44
@jailln jailln assigned Neptilo and unassigned jailln Apr 27, 2026

@Neptilo Neptilo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The detaied function and class comments are appreciated. :)

Comment thread packages/Geographic/src/Extent.ts Outdated
Comment thread packages/Geographic/test/unit/extent.js Outdated
Comment thread packages/Main/src/Core/Tile/Tile.ts Outdated
Comment thread packages/Main/src/Core/Tile/Tile.ts Outdated
Comment thread packages/Main/src/Layer/TiledGeometryLayer.js Outdated
Comment thread packages/Main/src/Source/Source.js Outdated
Comment thread packages/Geographic/src/Extent.ts Outdated
Comment thread packages/Main/src/Source/TMSSource.js
Comment thread packages/Geographic/src/Extent.ts Outdated
@gchoqueux
gchoqueux force-pushed the refacto/source_hasdata branch 3 times, most recently from 7b795c7 to 7d9867b Compare April 30, 2026 13:28
@gchoqueux
gchoqueux force-pushed the refacto/source_hasdata branch 5 times, most recently from f8408e3 to adb165f Compare May 13, 2026 11:24
Comment thread packages/Main/src/Core/Tile/Tile.ts Outdated
@gchoqueux
gchoqueux force-pushed the refacto/source_hasdata branch 4 times, most recently from c66f88b to 565fd99 Compare May 18, 2026 09:05
@gchoqueux
gchoqueux force-pushed the refacto/source_hasdata branch from 565fd99 to f154537 Compare May 18, 2026 11:48
@Neptilo
Neptilo self-requested a review May 19, 2026 12:43
@gchoqueux
gchoqueux merged commit 3c64961 into iTowns:master May 20, 2026
12 checks passed
@gchoqueux
gchoqueux deleted the refacto/source_hasdata branch May 20, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants