Repository navigation
Add confirmed self-uninstall for SimStore - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SimStore → Uninstall SimStore… with confirmation showing the running application's path. Remove the app bundle, caches, preferences, saved state, and owned temporary directories, then force the target process to exit. The existing native assistant verifies the bundle and PID and pauses the app during cleanup so background work cannot recreate its files.
Resume the app and report failures when cleanup cannot finish. Keep unrelated files and symlink targets, and disable uninstall during a SimStore update. Include English and Simplified Chinese strings and document cleanup in docs/cache.md.
Validation: Debug and Release builds, all 23 Release CTest checks, the Debug preview test, and strict swift-format lint passed. Native confirmation tests cover cancellation and errors. Integration tests uninstall isolated app copies, verify preference and temporary-file removal and process termination, reject unrelated PIDs, and verify recovery after a deletion failure. App launch and window lifecycle checks also passed.