Repository navigation
Cache app icons in memory and on disk - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App cards and detail sheets now share an icon cache, avoiding repeated downloads and retaining icons across app restarts. Cache entries use the release asset URL and recipe revision so a new build gets a fresh icon while catalog metadata changes reuse existing entries.
Decoded images use a 32 MiB NSCache target and a maximum edge of 256 pixels. Original image bytes use a 64 MiB disk LRU cache. Matching requests share a task, with at most four concurrent downloads; canceled views discard results without canceling other callers. Corrupt disk entries are fetched again, and persistence failures do not hide valid images.
Document both icon and existing index.json caching policies in docs/cache.md.
Validation: