Fix out of memory crash when pausing game - #93
Conversation
…hunkGenerationManager
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesChunk generation pause handling
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Fixes #91
ChunkGenerationManager.initialize()resetspauseCheckback to its default:Even though that
pauseCheckis already set to the default value of false when creating the class. And since this initialization function is run afteronInitializeClientfrom the classVoxyWorldGenV2Client,setPauseCheckis ignored. You can verify this yourself in any log from the game: the mod'sinitializing voxy world gen v2 client line(from the client entry point) appears near the top of the log during startup, whileserver started, initializing manager appears later, each time you load a world.This fix was verified on 26.2 using both Fabric and NeoForge. The worker stops dispatching new generation tasks while the pause menu is open after this change, and the heap stays stable over a long paused session that previously would OOM.
Summary by CodeRabbit