docs: add MSP async data access pattern doc - #2691
Merged
sensei-hacker merged 1 commit intoJul 21, 2026
Merged
Conversation
Documents a recurring async-race bug shape (MSP data accessed before its load callback fires, or two independent load chains racing each other) using the real fix in tabs/osd.js's OSD.reload()/OSD.GUI.updateAll() chain as a worked example.
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
|
Configurator test build ready — commit Download build artifacts for PR #2691 Available platforms (scroll to the Artifacts section at the bottom of the run page):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a developer-docs pattern doc for a recurring async-race bug shape: MSP data accessed before its load callback fires, or two independent load chains racing each other before touching the same result.
Uses the OSD tab's
OSD.reload()/OSD.GUI.updateAll()chain as a worked, verified-against-current-source example (custom OSD elements + Logic Conditions "configured" mask both loading beforecreateCustomElements()runs,getLCoptions()guarding on the mask).Test plan
tabs/osd.jsandjs/msp/MSPHelper.jssource (not just the original draft's claims)