Skip to content

Upgrade Node.js to 24 and bump GitHub Actions#455

Merged
ardelato merged 3 commits into
masterfrom
feat/bump-node-version
Jun 5, 2026
Merged

Upgrade Node.js to 24 and bump GitHub Actions#455
ardelato merged 3 commits into
masterfrom
feat/bump-node-version

Conversation

@ardelato
Copy link
Copy Markdown
Contributor

@ardelato ardelato commented Jun 5, 2026

Description

Addresses the pulldasher items from iFixit/ifixit#62294. Pulldasher was P0 — still using @v3 actions (Node 16 runtime, already deprecated) and running on Node 18 (EOL since April 2025).

This upgrades all Node.js and CI configuration ahead of the June 16, 2026 deadline when GitHub forces all node20 actions to Node 24.

Changes

  • GitHub Actions: actions/checkout@v3@v6, actions/setup-node@v3@v5
  • Node.js version: 18 → 24 in CI workflow, Dockerfile, and new .nvmrc
  • Engines constraint: Added "node": ">=24.0.0 <25.0.0" to package.json

Test plan

  • CI build passes (lint + webpack build under Node 24)
  • Docker build succeeds with node:24-alpine
  • Verify pulldasher starts and serves the dashboard

ardelato added 3 commits June 5, 2026 09:55
checkout@v3 and setup-node@v3 use the Node 16 runtime which is
already deprecated. Upgrading to checkout@v6 and setup-node@v5
moves to the Node 20+ runtime ahead of the June 16 enforcement.
Node 18 reached end-of-life in April 2025. Upgrading the CI
workflow, Dockerfile, and adding an .nvmrc to target Node 24,
which becomes LTS in October 2026.
Codifies the supported Node version range so npm install fails
early if someone tries to use an unsupported version.
Copy link
Copy Markdown
Contributor

@ianrohde ianrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ⚪

We just did this over on the expo repo 👍

@ardelato
Copy link
Copy Markdown
Contributor Author

ardelato commented Jun 5, 2026

QA 👍 Pulldasher container ran with the new node version.
image

@ardelato ardelato merged commit ffd4c5a into master Jun 5, 2026
1 check passed
@ardelato ardelato deleted the feat/bump-node-version branch June 5, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants