Fix dol Issue #18 in ModuleNamesImportedByModule.print_kvs - #2
Merged
Conversation
print_kvs iterated self.items() from inside the wrap_kvs-decorated class, where `self` is the inner unwrapped store whose keys are module OBJECTS, not the key_of_id-decoded module NAME strings — so it printed "<Module: json.decoder>" reprs instead of "json.decoder". Route through dol.wrapped_self(self) (the outer, transform-applying store). Requires dol>=0.3.49 (wrapped_self). Refs i2mint/dol#18 Claude-Session: https://claude.ai/code/session_01H8PmV6xmMhzV64zi1Twraw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
print_kvsiteratedself.items()from inside the@wrap_kvs(key_of_id=modobj_to_modname, ...)-decorated class, whereselfis the inner unwrapped store — so its keys are module objects, not the decoded module-name strings. It printed<Module: json.decoder>reprs instead ofjson.decoder.Fix: route through
dol.wrapped_self(self)(the outer, transform-applying store). Verified locally:print_kvsnow prints module name strings. Requiresdol>=0.3.49(shipswrapped_self).No regression test added (repo has no test suite). Refs i2mint/dol#18.
https://claude.ai/code/session_01H8PmV6xmMhzV64zi1Twraw